-
Notifications
You must be signed in to change notification settings - Fork 189
Use default TLS port if scheme is HTTPS #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
3dafef7
to
5a09679
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Not sure what else to do here. The CLA was signed, sent and approved. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@nfantone sorry for the delay, CLAs are verified and processed by hand so it usually takes couple of days :) We are all set here! |
@nfantone please take a look at the failed tests |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nicolás Fantone.
|
5800615
to
03fc622
Compare
@wendigo Thanks for moving this forward. All tests are passing now. |
Description
Uses either
DEFAULT_TLS_PORT
(443
) orDEFAULT_PORT
(8080
) if no explicit port is provided, based on the HTTP scheme of the connection URI.Release notes